This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(attachment) - more option button invoke correctly action on space/enter#1452
Merged
fix(attachment) - more option button invoke correctly action on space/enter#1452
Conversation
kolaps33
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Collaborator
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #1452 +/- ##
=========================================
Coverage ? 73.21%
=========================================
Files ? 822
Lines ? 6194
Branches ? 1782
=========================================
Hits ? 4535
Misses ? 1654
Partials ? 5
Continue to review full report at Codecov.
|
kolaps33
added
accessibility
jurokapsiar
reviewed
Jun 15, 2019
| performClick = e => { | ||
| e.stopPropagation() | ||
| this.handleClick(e) | ||
| if (e.currentTarget === e.target) { |
Contributor
There was a problem hiding this comment.
based on agreement with @layershifter and @miroslavstastny this is ok for now, but it shows a bigger issue we have related to click handling of components that have parent/child clickable elements, especially if the elements trigger click on keyboard events (button, a)
This might help move the logic to behaviors: #1502
jurokapsiar
approved these changes
Jun 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see more details:
"Enter" key on "More option" button in attachment, invoke click on whole attachment #1450