feat(Icon): Icons for screen sharing control in the calling screen#1490
Conversation
jay-howe
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1490 +/- ##
==========================================
+ Coverage 73.44% 73.45% +0.01%
==========================================
Files 818 822 +4
Lines 6179 6183 +4
Branches 1793 1793
==========================================
+ Hits 4538 4542 +4
Misses 1636 1636
Partials 5 5
Continue to review full report at Codecov.
|
alinais
changed the title
...ges/react/src/themes/teams/components/Icon/svg/ProcessedIcons/icons-call-control-request.tsx
Show resolved
Hide resolved
…jaya/screensharing-control-viewer-icons
|
@codepretty, could you, please, take a look and verify SVG paths/viewport size/name for the introduced icon? Thank you! |
| 'call-parking': callParking, | ||
| 'call-video': callVideo, | ||
| 'call-video-off': callVideoOff, | ||
| 'call-control-release': callControlRelease, |
There was a problem hiding this comment.
lets ensure those are pasted in alphabetical order to the set of other ones
There was a problem hiding this comment.
agreed to keep 'concepts-based' order
| import calendar from './calendar' | ||
| import call from './call' | ||
| import callParking from './callParking' | ||
| import callControlRelease from './callControlRelease' |
There was a problem hiding this comment.
lets maintain alphabetical order, to simplify search scenarios
There was a problem hiding this comment.
I am keeping release and request as a group (viewer) as they are most closely related. The other call-control-xxx icons are a different group (sender)
There was a problem hiding this comment.
I have grouped them by concepts as opposed to lexical order.
There was a problem hiding this comment.
The existing list is already out of order. Do you want me to fix it?
There was a problem hiding this comment.
no, lets stick to the order pattern already established - thank you for clarification!
kuzhelov
left a comment
kuzhelov
left a comment
There was a problem hiding this comment.
please, just add changelog entry
3 participants
Problem description
Please port the new ubar icons for screen sharing control to StarDust