This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(Button): Update text button styles#1719
Merged
codepretty merged 20 commits intomasterfrom Aug 12, 2019
Merged
Conversation
codepretty
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1719 +/- ##
==========================================
- Coverage 69.77% 69.75% -0.02%
==========================================
Files 867 867
Lines 7354 7356 +2
Branches 2159 2138 -21
==========================================
Hits 5131 5131
- Misses 2215 2217 +2
Partials 8 8
Continue to review full report at Codecov.
|
mnajdova
reviewed
Jul 25, 2019
docs/src/examples/components/Button/Types/ButtonExampleText.tsx
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
Jul 25, 2019
packages/react/src/themes/teams/components/Button/buttonStyles.ts
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
Jul 25, 2019
packages/react/src/themes/teams-dark/components/Button/buttonVariables.ts
Show resolved
Hide resolved
mnajdova
reviewed
Jul 25, 2019
docs/src/examples/components/Button/Types/ButtonExampleIconOnly.shorthand.tsx
Show resolved
Hide resolved
alinais
approved these changes
Aug 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated text button styles to match redlines and have the correct hover/focus states. Also, reorganized some of the buttons doc page.
BEFORE
AFTER
Dark theme
Contrast theme
