feat(docs): remove Font Awesome icons from examples

[lucivpav]

Overview
There are examples in docs that use Font Awesome icons. If such an example snippet is run on e.g. Codesandbox, the icons are not rendered at all, due to missing Font Awesome. The Font Awesome should not be used in docs at all. Relevant issue #1762

Changes

1. Font Awesome theme is no longer merged with Teams theme in app.tsx of docs
2. All icon usages in code examples are from Teams theme
3. GitHub icon has been added to Teams theme
4. arrow-left, arrow-right were added to Teams theme (they are taken from ProcessedIcons folder)

TODO
We need the following icons, that are currently missing from the Teams theme (they are also not in processedIcons):

• Copy, Copy outline
• Spinner
• Align right
• Minus
• Clock
• Thumbs down (aka Dislike)
• Folder
• Folder open
• User

[codecov]

Codecov Report

Merging #1764 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1764      +/-   ##
==========================================
+ Coverage   69.76%   69.77%   +<.01%     
==========================================
  Files         868      870       +2     
  Lines        7484     7486       +2     
  Branches     2176     2200      +24     
==========================================
+ Hits         5221     5223       +2     
  Misses       2255     2255              
  Partials        8        8

Impacted Files	Coverage Δ
...emes/teams/components/Icon/svg/icons/arrowLeft.tsx	100% <100%> (ø)
...mes/teams/components/Icon/svg/icons/arrowRight.tsx	100% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3485b5...92edeb2. Read the comment docs.

[levithomason]

Quick clarification, the Teams theme shouldn't use FontAwesome icons. However, other themes may use FontAwesome icons. It is also OK for the doc site itself to use FontAwesome icons.

I think only the actual examples files in docs/src/examples should avoid FontAwesome icons, and only for now while we work out icon name inconsistency issues. However, this is also a temporary solution since switching the theme to anything other than Teams will also break once all the icons are switched to Teams.

Suggestions and reasoning:

• Move forward with removing FontAwesome icon names from examples only
  Just a temporary solution since the main theme being worked on is Teams right now. This will have to updated again in the near future as soon as we start adding other themes. Theme switching from Teams to something else should still work.

• Leave FontAwesome support in Stardust
  Other themes likely will use it since it is the most popular and has a free license. Most likely, will provide a base theme which also uses FontAwesome.

• Leave the doc site on FontAwesome icons
  Stardust is not a Microsoft product but a general open source library. We don't want to associate our docs with Microsoft's product glyphs.

[levithomason]

See above

[lucivpav]

@levithomason I have updated this PR. Only the example code snippets are using Teams icons instead of Font Awesome icons. The usages of missing icons from Teams theme were replaced by other meaningful icons from Teams, so that we don't need to ask for new icons from the design team.

[miroslavstastny]

Let only design add icons. Use arrow-up and rotate it as needed.

[lucivpav]

The two icons arrow-left, arrow-right are simply copied from ProcessedIcons folder. I did not design them.

[miroslavstastny]

As @levithomason mentioned - this is general doc, I would stick with FA here.

[lucivpav]

Are you sure? If user copies these code examples into the codesandbox template, the icons won't render.

[miroslavstastny]

I am not sure, but let's go with what you have now.

[miroslavstastny]

Make sure you accept screen changes before merging.

PR updated as requested

[vercel]

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://stardust-react-git-feat-no-font-awesome-in-docs.stardust-ui.now.sh