This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(Focus): focus indicator for additional documents#1816
Merged
layershifter merged 5 commits intomasterfrom Aug 19, 2019
Merged
feat(Focus): focus indicator for additional documents#1816layershifter merged 5 commits intomasterfrom
layershifter merged 5 commits intomasterfrom
Conversation
Codecov Report
Continue to review full report at Codecov.
|
Member
layershifter
left a comment
There was a problem hiding this comment.
There is also docElem with calls like:
docElem.setAttribute(`data-whatinput`, currentInput)
docElem.setAttribute('data-whatelement', currentElement)Should we also update it?
Contributor
Author
|
sophieH29
reviewed
Aug 19, 2019
layershifter
approved these changes
Aug 19, 2019
layershifter
pushed a commit
that referenced
this pull request
Aug 19, 2019
* focus indicator for additional documents * changelog * use document.defaultView * fix (cherry picked from commit 6a8864a)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add event handlers that detect input type to additional documents as well