This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(Dropdown): pass custom window to Downshift#1884
Merged
silviuaavram merged 5 commits intomasterfrom Sep 4, 2019
Merged
Conversation
silviuaavram
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
silviuaavram
added
accessibility
Codecov Report
@@ Coverage Diff @@
## master #1884 +/- ##
=======================================
Coverage 69.84% 69.84%
=======================================
Files 888 888
Lines 7762 7762
Branches 2269 2242 -27
=======================================
Hits 5421 5421
Misses 2331 2331
Partials 10 10
Continue to review full report at Codecov.
|
layershifter
reviewed
Sep 3, 2019
| highlightedIndex={highlightedIndex} | ||
| onStateChange={this.handleStateChange} | ||
| labelId={this.props['aria-labelledby']} | ||
| environment={this.context.target.defaultView} |
Member
There was a problem hiding this comment.
https://developer.mozilla.org/en-US/docs/Web/API/Document/defaultView
Works in IE11, I am happy 👍
Collaborator
Author
There was a problem hiding this comment.
the exact place I got it from!
delete-merged-branch
bot
deleted the
fix/pass-environment-to-downshift
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
downshift-js/downshift#755
Can be merged without the Downshift fix.