This repository was archived by the owner on Mar 4, 2020. It is now read-only.
perf: remove Box usages where it is redundant#2023
Merged
layershifter merged 2 commits intomasterfrom Oct 11, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2023 +/- ##
==========================================
- Coverage 75.8% 69.56% -6.25%
==========================================
Files 160 900 +740
Lines 5572 7977 +2405
Branches 1614 2311 +697
==========================================
+ Hits 4224 5549 +1325
- Misses 1334 2414 +1080
Partials 14 14
Continue to review full report at Codecov.
|
miroslavstastny
approved these changes
Oct 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Boxuntil there is a needThe idea of usage
Box/any other component with.create()is to provide access to slots via shorthands. However, in these cases we didn't expose these slots so there is no need inBox.create()as it creates additional performance overhead via computing styles forBox.🚀 Measures
Perf sample renders 100 attachments:
Diff is around 7.60%.
Before
After