This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(Debug): Check that owner exists#2055
Merged
miroslavstastny merged 5 commits intomasterfrom Oct 23, 2019
Merged
Conversation
miroslavstastny
requested review from
dvdzkwsk,
layershifter,
levithomason and
mnajdova
as code owners
jurokapsiar
approved these changes
Oct 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When showing a debug panel, check that debug owner exists.
Debug owner is the component which rendered the debugged component. There are cases where the debug owner is not in the React tree. Consider the following example:
If that is rendered as an example in DocSite using
ComponentExample, debug owner is not found.