This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(AutoControlledComponent): fix behaviour when undefined it passed#499
Merged
layershifter merged 3 commits intomasterfrom Nov 20, 2018
Merged
fix(AutoControlledComponent): fix behaviour when undefined it passed#499layershifter merged 3 commits intomasterfrom
layershifter merged 3 commits intomasterfrom
Conversation
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #499 +/- ##
=======================================
Coverage 88.41% 88.41%
=======================================
Files 42 42
Lines 1450 1450
Branches 211 186 -25
=======================================
Hits 1282 1282
Misses 163 163
Partials 5 5Continue to review full report at Codecov.
|
layershifter
commented
Nov 20, 2018
| if (!isNextUndefined) acc[prop] = nextProps[prop] | ||
| // reinitialize state for props just removed / set undefined | ||
| else if (propWasRemoved) acc[prop] = getAutoControlledStateValue(prop, nextProps) | ||
| if (isNextDefined) acc[prop] = nextProps[prop] |
Member
Author
There was a problem hiding this comment.
In fact, we don't need to do something with undefined at all. We should update the state only for defined values from props
layershifter
changed the title
layershifter
added
🚀 ready for review
🧰 fix
bmdalex
approved these changes
Nov 20, 2018
mnajdova
approved these changes
Nov 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We discussed this changes during meetings on the previous week, we need to change the behaviour of
AutoControlledComponentto match React's.An example that shows issue: https://codesandbox.io/s/l20mjn74zz
After this PR we can safely migrate to
getDerivedStateFromProps()👍