This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(docs): component styles in RTL mode#579
Merged
Conversation
kuzhelov
requested review from
dvdzkwsk,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
levithomason
reviewed
Dec 7, 2018
|
|
||
| return <Provider theme={newTheme}>{element}</Provider> | ||
| return ( | ||
| <Provider key={`${examplePath}${showRtl ? '-rtl' : ''}`} theme={newTheme}> |
Member
There was a problem hiding this comment.
Perhaps this should be done in the Provider itself? It seems adding it here would means RTL will work in our doc examples, but not necessarily anywhere else the Provider is used.
Contributor
Author
There was a problem hiding this comment.
not sure, as there is no straightforward way to generate the key (as we won't like to generate a new one on each rerendering). Should we request client to provide it?
Contributor
Author
There was a problem hiding this comment.
or you would suggest to do it here?
// Provider.ts
...
<ProviderConsumer
render={(incomingTheme: ThemePrepared) => {
const outgoingTheme: ThemePrepared = mergeThemes(incomingTheme, theme)
return (
<RendererProvider renderer={outgoingTheme.renderer} {...{ rehydrate: false }}>
<ThemeProvider key={outgoingTheme.isRtl ? 'rtl' : 'ltr'} theme={outgoingTheme}>{children}</ThemeProvider>
</RendererProvider>
)
}}
/>
levithomason
approved these changes
Dec 7, 2018
Member
levithomason
left a comment
levithomason
left a comment
There was a problem hiding this comment.
Just add a TODO and link to this issue to fix it in the Provider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently all the component styles are broken for docs in RTL mode. This PR fixes this problem.
TODO
What was the issue
The root cause of that is the fact that Fela updates subscription to the DOM node where styles should be rendered to (i.e
<head> -> <styles>) only on its Provider component being mounted.It turns out that our rendering loigc hasn't guaranteed that new Fela's
Providerwill be mounted with RTL switch - and, this, the logic of <style> DOM node subscription wasn't fired for RTL renderer.Fixes: #582
Follow-up, general issue: #581