This repository was archived by the owner on Mar 4, 2020. It is now read-only.
Merged
Conversation
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
layershifter
force-pushed
the
feat/loader
branch
from
d856f9f to
7252f4f
Compare
layershifter
force-pushed
the
feat/loader
branch
from
7252f4f to
5b46584
Compare
Member
Author
|
@jurokapsiar Juraj, please take a look on this PR. It seems that we need to add there some accessibility attributes. |
layershifter
changed the title
…ust-ui/react into feat/loader # Conflicts: # CHANGELOG.md
Member
Author
Thanks to @mnajdova for suggestions. |
…at/loader # Conflicts: # CHANGELOG.md
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #666.
Initial specification: stardust-ui/specifications#5
LoadervsSpinner,Indicator...See spec.
Missing
colorpropWill be added after #647.
labelvscontent/childrenSUIR calls this text, Fabric calls this label. Also, this part is a slot, so it cannot be directly children.
Opened there for feedback.