feat(prototypes): mention scenario with dropdown#931
Conversation
4d55c7b to
6340697
Compare
Codecov Report
@@ Coverage Diff @@
## master #931 +/- ##
==========================================
+ Coverage 80.38% 80.39% +<.01%
==========================================
Files 657 657
Lines 8398 8396 -2
Branches 1488 1488
==========================================
- Hits 6751 6750 -1
+ Misses 1632 1631 -1
Partials 15 15
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #931 +/- ##
==========================================
+ Coverage 80.42% 80.43% +0.01%
==========================================
Files 659 659
Lines 8412 8412
Branches 1488 1424 -64
==========================================
+ Hits 6765 6766 +1
+ Misses 1632 1631 -1
Partials 15 15
Continue to review full report at Codecov.
|
f75d795 to
27e2526
Compare
Codecov Report
@@ Coverage Diff @@
## master #931 +/- ##
==========================================
- Coverage 80.51% 80.51% -0.01%
==========================================
Files 659 659
Lines 8448 8447 -1
Branches 1492 1428 -64
==========================================
- Hits 6802 6801 -1
Misses 1631 1631
Partials 15 15
Continue to review full report at Codecov.
|
27e2526 to
7b055c8
Compare
Generated by 🚫 dangerJS |
7b055c8 to
edc801c
Compare
de6bc33 to
160a298
Compare
- refactoring of using portal - fix for all styling regressions
- fixed bug with text not being inserted when dropdown is closed; - small refactoring of CustomPortal -> PortalAtCursorPosition
160a298 to
8ab6fa2
Compare
kuzhelov
left a comment
There was a problem hiding this comment.
nice work 👍 just couple of things that I would like to be addressed before merge (apart from minor comments:
- sizing for
inputslot of dropdown input (could we remove thissizealtogether?): https://github.com/stardust-ui/react/pull/931/files#r259296667 - at-mentions dropdown is opened on
2character typed: https://github.com/stardust-ui/react/pull/931/files#r259297611
|
thanks @kuzhelov , here are my responses:
see: #931 (comment)
fixed |
kuzhelov
left a comment
There was a problem hiding this comment.
please, just introduce changelog entry before merging 👍
feat(prototypes): mention scenario with dropdown
Description
This PR attempts to create a prototype to show users how they can mention people using
@key in a rich text editor.I am using a
contentEditablediv as rich text input and theDropdowncomponent to leverage the list of users and filtering through them. The rest of the functionality is in the prototype sectionScreenshot
Issues:
Later edit:
all issues and blocking items for this PR are fixed