Skip to content

HOTFIX: Community module multiple definition error fix#52

Merged
stasmarkin merged 3 commits intostasmarkin:mainfrom
TickKleiner:main
Nov 18, 2025
Merged

HOTFIX: Community module multiple definition error fix#52
stasmarkin merged 3 commits intostasmarkin:mainfrom
TickKleiner:main

Conversation

@TickKleiner
Copy link
Copy Markdown
Contributor

Fix multiple definition errors in QMK Community Modules

Split header-only implementation into separate .h/.c files to resolve
linker conflicts when using Community Module system. Fixes issue where
keymap introspection would duplicate function definitions from sm_td.h.

@stasmarkin
Copy link
Copy Markdown
Owner

Hey! Thank you for your fix!
Don't you mind if I add some changes in your PR?
Tests are now broken and I wnat to fix them before merging

@stasmarkin
Copy link
Copy Markdown
Owner

Well, I tried to push into that PR, but it's impossible since it's a separate repository.
Could you please merge my last two commits into your PR from here main...TickKleiner/main @TickKleiner
I will merge this PR with that changes

@TickKleiner
Copy link
Copy Markdown
Contributor Author

@stasmarkin Done!
Sorry, stuck at work

@stasmarkin stasmarkin merged commit 2b277c7 into stasmarkin:main Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants