Skip to content

fix proposal execution head at genesis; rm non-spec SSE; ensure envelopse SSE has envelope in database#8340

Merged
tersec merged 1 commit into
unstablefrom
cWK
Apr 27, 2026
Merged

fix proposal execution head at genesis; rm non-spec SSE; ensure envelopse SSE has envelope in database#8340
tersec merged 1 commit into
unstablefrom
cWK

Conversation

@tersec
Copy link
Copy Markdown
Contributor

@tersec tersec commented Apr 27, 2026

For the proposal head at genesis, even though

states

        state.latest_block_hash = spec.Hash32()
        empty_requests_root = spec.hash_tree_root(spec.ExecutionRequests())
        state.latest_execution_payload_bid = spec.ExecutionPayloadBid(
            block_hash=spec.Hash32(eth1_block_hash),

the current generator does the opposite of this. So, work around this mismatch.

Should be removed when the generator is fixed.

According to https://github.com/ethereum/beacon-APIs/blob/v5.0.0-alpha.1/apis/eventstream/index.yaml execution_payload_available and execution_payload_bid exist but plain execution_payload does not.

@github-actions
Copy link
Copy Markdown

Unit Test Results

       12 files  ±0    2 816 suites  ±0   1h 16m 1s ⏱️ - 5m 2s
15 853 tests ±0  14 288 ✔️ ±0  1 565 💤 ±0  0 ±0 
76 516 runs  ±0  74 776 ✔️ ±0  1 740 💤 ±0  0 ±0 

Results for commit 1f7e493. ± Comparison against base commit c796b98.

@ahshum
Copy link
Copy Markdown
Contributor

ahshum commented Apr 27, 2026

Is the eventstream topic causing the issue? Yes it is right that the topics not exists because the beacon-API PR has not been merged yet #8183

But seems that other clients have merged the changes according to the references in the beacon-API PR.

@tersec tersec merged commit b99895a into unstable Apr 27, 2026
11 checks passed
@tersec tersec deleted the cWK branch April 27, 2026 07:38
@tersec
Copy link
Copy Markdown
Contributor Author

tersec commented Apr 27, 2026

Is the eventstream topic causing the issue? Yes it is right that the topics not exists because the beacon-API PR has not been merged yet #8183

But seems that other clients have merged the changes according to the references in the beacon-API PR.

Ah,

merged 4 hours ago, after I opened this PR and enabled auto-merge.

It wasn't per se causing problems, no, but when I was looking into where to put the onEnvelopeAvailable callback, it proved redundant, and at the time, it was... not in specs.

It can be added back, in the correct place.

@alialobidm
Copy link
Copy Markdown

``

@alialobidm alialobidm mentioned this pull request Apr 28, 2026
Closed
@alialobidm
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants