This repository was archived by the owner on Nov 1, 2023. It is now read-only.
Ipaddress parse fix to handle X-Forwarded-For with ports#83
Merged
stefanprodan merged 5 commits intostefanprodan:masterfrom Dec 8, 2016
Merged
Ipaddress parse fix to handle X-Forwarded-For with ports#83stefanprodan merged 5 commits intostefanprodan:masterfrom
stefanprodan merged 5 commits intostefanprodan:masterfrom
Conversation
Owner
|
What about Ipv6? |
Author
the simplest test case ::1 would get pretty butchered, yes. Thanks, I'll submit an update! |
Owner
|
Also IsPrivateIpAddress does not handle Ipv6 I think. |
Author
|
added ipv6 handling |
stefanprodan
approved these changes
Dec 8, 2016
Owner
|
Thanks, your fixes are included on v1.5.2.0 and I've deployed the packages on NuGet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had the same problem as #34 with X-Forwarded-For containing port numbers. This pull request adds add check for port numbers and removes them before using the same parse logic as previously.
It also adds a test project for the parse code.