-
Notifications
You must be signed in to change notification settings - Fork 5
(towards #75) Adds original tracer advection benchmark #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
OpenMP version runs on my desktop but doesn't show any performance benefit. However, OMP is not in the ESIWACE2 deliverable so I'm going to park that for now. |
|
I need to add a checksum output to ease verification. |
|
Now have version with compute moved to subroutine working on GPU. However, can see that we get managed-memory traffic at the start of each compute region: I think this must be because a lot of the work arrays are done as automatic arrays and thus are re-allocated on the GPU each time the subroutine is called. |
|
Presumably @rupertford, this solution won't work for SIR because I now have an allocate in the compute routine itself? I could move it out to an |
I'm not actually sure. It may be OK as you can specify data as being local in the SIR which presumably means scoped within the code generated by SIR. But I've not looked at what gets generated. |
…t end of benchmark run.
rupertford
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Just a few comments inline.
benchmarks/nemo/tracer_advection/compute_in_subroutine/tra_adv_compute_auto_arrays.F90
Outdated
Show resolved
Hide resolved
|
Ready for another look from @rupertford now. |
rupertford
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of docstrings that have not been updated. Please see inline.
|
OK, this should be ready to go now. |
rupertford
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now.


Uh oh!
There was an error while loading. Please reload this page.