This repository was archived by the owner on Jul 3, 2023. It is now read-only.
remove unused imports#218
Merged
skrawcz merged 1 commit intostitchfix:mainfrom Oct 28, 2022
jameslamb:unused-imports
Merged
Conversation
Closed
skrawcz
approved these changes
Oct 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #161.
Changes
Removes unused imports to resolve the following
flake8warnings.Testing
Ran the
pre-commitstuff.Ran the the tests in a container using the
circleci/python:3.8image locally.testing details (click me)
docker run \ --rm \ -v $(pwd):/usr/local/src \ --workdir /usr/local/src \ --entrypoint="" \ -it circleci/python:3.8 \ /bin/bashAnd then installed hamilton and ran its tests.
Notes
In addition to all the other benefits of removing unused code, this specific change (removing unused imports) should slightly speed up the time it takes to import
hamiltonand to run its tests.Thanks for your time and consideration.
Checklist
Testing checklist
Python - local testing