Skip to content
This repository was archived by the owner on Jul 3, 2023. It is now read-only.

remove unnecessary code in tests#221

Merged
skrawcz merged 1 commit intostitchfix:mainfrom
jameslamb:remove-unused-stuff-in-tests
Oct 28, 2022
Merged

remove unnecessary code in tests#221
skrawcz merged 1 commit intostitchfix:mainfrom
jameslamb:remove-unused-stuff-in-tests

Conversation

@jameslamb
Copy link
Copy Markdown
Contributor

Contributes to #161.

Changes

  • removes one instance of duplicated test test_tags_invalid_value (code link)
  • removes unused variable in one Dask test

These were detected by flake8.

./tests/test_function_modifiers.py:744:1: F811 redefinition of unused 'test_tags_invalid_value' from line 739
./graph_adapter_tests/h_dask/test_h_dask.py:49:5: F841 local variable 'index' is assigned to but never used

Testing

pre-commit run --all-files

Notes

Thanks for your time and consideration.

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Python - local testing

  • python 3.6
  • python 3.7

@jameslamb jameslamb mentioned this pull request Oct 28, 2022
@skrawcz skrawcz merged commit 931c01d into stitchfix:main Oct 28, 2022
@jameslamb jameslamb deleted the remove-unused-stuff-in-tests branch October 28, 2022 04:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants