Skip to content
This repository was archived by the owner on Jul 3, 2023. It is now read-only.

Fixes dbt integration to be much cleaner using FAL integration#239

Merged
elijahbenizzy merged 1 commit intomainfrom
dbt-fal-hamilton
Nov 29, 2022
Merged

Fixes dbt integration to be much cleaner using FAL integration#239
elijahbenizzy merged 1 commit intomainfrom
dbt-fal-hamilton

Conversation

@elijahbenizzy
Copy link
Copy Markdown
Collaborator

@elijahbenizzy elijahbenizzy commented Nov 29, 2022

Still TBD on exactly how this works -- need to read into FAL more, but it seems to work just fine and kills all the ugly code. Thanks FAL!

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Still TBD on exactly how this works -- need to read into FAL more,
but it seems to work just fine and kills all the ugly code. Thanks FAL!
@elijahbenizzy elijahbenizzy merged commit 4d19d12 into main Nov 29, 2022
@elijahbenizzy elijahbenizzy deleted the dbt-fal-hamilton branch November 29, 2022 15:37
@burkaygur
Copy link
Copy Markdown

This looks great! 🚢 🙌

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants