Skip to content

fix(tianmu): fix bug: Convert DATETIME to TIME type error. (#995)#1073

Merged
mergify[bot] merged 2 commits intostoneatom:stonedb-5.7-devfrom
lujiashun:fix-995-stonedb5.7
Dec 8, 2022
Merged

fix(tianmu): fix bug: Convert DATETIME to TIME type error. (#995)#1073
mergify[bot] merged 2 commits intostoneatom:stonedb-5.7-devfrom
lujiashun:fix-995-stonedb5.7

Conversation

@lujiashun
Copy link
Copy Markdown

@lujiashun lujiashun commented Dec 6, 2022

Summary about this PR

Issue Number: close #995

[summary]
1 treat zero data legal;

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 6, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Dec 6, 2022
@lujiashun lujiashun marked this pull request as draft December 6, 2022 03:04
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 6, 2022

Codecov Report

Base: 33.88% // Head: 33.77% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (a29a603) compared to base (bd6ee07).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head a29a603 differs from pull request most recent head 0bfe29e. Consider uploading reports for the commit 0bfe29e to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1073      +/-   ##
===================================================
- Coverage            33.88%   33.77%   -0.11%     
===================================================
  Files                 1807     1807              
  Lines               395050   394956      -94     
===================================================
- Hits                133860   133412     -448     
- Misses              261190   261544     +354     
Impacted Files Coverage Δ
storage/tianmu/core/item_tianmu_field.cpp 90.16% <100.00%> (-0.11%) ⬇️
storage/innobase/include/ut0mutex.ic 30.95% <0.00%> (-16.67%) ⬇️
storage/tianmu/loader/value_cache.h 50.00% <0.00%> (-14.59%) ⬇️
storage/tianmu/system/io_parameters.h 58.20% <0.00%> (-8.46%) ⬇️
client/mysqltest.cc 41.30% <0.00%> (-7.43%) ⬇️
storage/tianmu/loader/load_parser.cpp 58.16% <0.00%> (-5.23%) ⬇️
sql/sql_load.cc 3.38% <0.00%> (-3.00%) ⬇️
storage/innobase/include/ib0mutex.h 61.94% <0.00%> (-2.24%) ⬇️
storage/tianmu/core/tianmu_attr_typeinfo.h 78.57% <0.00%> (-2.08%) ⬇️
storage/tianmu/loader/parsing_strategy.cpp 54.54% <0.00%> (-1.47%) ⬇️
... and 31 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lujiashun lujiashun requested a review from wisehead December 8, 2022 02:00
@lujiashun lujiashun marked this pull request as ready for review December 8, 2022 02:16
Copy link
Copy Markdown
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 2a03448 into stoneatom:stonedb-5.7-dev Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-bug bug for pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Convert DATETIME to TIME type error

3 participants