fix(tianmu): fix Update multiple values does not work (#781)#1094
fix(tianmu): fix Update multiple values does not work (#781)#1094mergify[bot] merged 2 commits intostoneatom:stonedb-5.7-devfrom adofsauron:stonedb-5.7-dev
Conversation
|
This pull request's title should follow requirements next. @adofsauron please check it 👇. Valid format: Valid types:
|
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
Codecov ReportBase: 33.89% // Head: 33.91% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## stonedb-5.7-dev #1094 +/- ##
===================================================
+ Coverage 33.89% 33.91% +0.02%
===================================================
Files 1807 1807
Lines 395052 395055 +3
===================================================
+ Hits 133912 133995 +83
+ Misses 261140 261060 -80
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Cause of error:
Update multiple values does not work with WHERE IN
clause Update multiple values does not work with where in clause.
Predicate push-down from TIANMU is used, and this process works fine.
But when you get the direct result,
it is not compatible with TIANMU's dimen_group concrete type.
In the execution of a predicate push-down,
must get the Filter so that the execution of the follow-up to value,
namely DimensionGroupFilter,
but the current statement USES the materialized DimensionGroupMaterialized operation
Solution Strategy:
If the query is executed by a predicate pushdown, materialization is not enabled
What remains:
When no materialization operation is used in predicate push-down,
the impact on query performance of predicate push-down
needs to be cross-checked against benchmarks
Summary about this PR
Issue Number: close #781
Tests Check List
Changelog
Documentation