Skip to content

feat(tianmu): support select into outfile with enclosed char. (#850,#1006)#1112

Merged
mergify[bot] merged 1 commit into
stoneatom:stonedb-5.7-devfrom
lujiashun:feat-850-stonedb5.7
Dec 15, 2022
Merged

feat(tianmu): support select into outfile with enclosed char. (#850,#1006)#1112
mergify[bot] merged 1 commit into
stoneatom:stonedb-5.7-devfrom
lujiashun:feat-850-stonedb5.7

Conversation

@lujiashun
Copy link
Copy Markdown

Summary about this PR

Issue Number: close #850 #1006
[summary]
1 support select into out-file can output enclose char(optionally or not);
2 support load with enclose char(optionally or not);

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@lujiashun lujiashun marked this pull request as draft December 13, 2022 05:21
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Dec 13, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify Bot added the PR-feature feature for pull request label Dec 13, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 13, 2022

Codecov Report

Base: 42.63% // Head: 34.05% // Decreases project coverage by -8.58% ⚠️

Coverage data is based on head (9643f53) compared to base (1a81c64).
Patch coverage: 84.61% of modified lines in pull request are covered.

❗ Current head 9643f53 differs from pull request most recent head 4daf6a5. Consider uploading reports for the commit 4daf6a5 to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1112      +/-   ##
===================================================
- Coverage            42.63%   34.05%   -8.59%     
===================================================
  Files                 1830     1807      -23     
  Lines               395930   395069     -861     
===================================================
- Hits                168813   134523   -34290     
- Misses              227117   260546   +33429     
Impacted Files Coverage Δ
storage/tianmu/system/io_parameters.h 74.62% <0.00%> (+6.44%) ⬆️
storage/tianmu/exporter/data_exporter_txt.cpp 63.49% <85.71%> (+63.49%) ⬆️
storage/tianmu/loader/parsing_strategy.cpp 61.56% <85.71%> (+1.21%) ⬆️
storage/tianmu/core/engine.cpp 51.79% <100.00%> (+0.78%) ⬆️
storage/tianmu/exporter/data_exporter_txt.h 57.14% <100.00%> (+57.14%) ⬆️
mysys_ssl/my_aes.cc 0.00% <0.00%> (-100.00%) ⬇️
strings/my_stpmov.c 0.00% <0.00%> (-100.00%) ⬇️
storage/innobase/include/fsp0fsp.h 0.00% <0.00%> (-100.00%) ⬇️
storage/innobase/include/row0ext.ic 0.00% <0.00%> (-100.00%) ⬇️
storage/innobase/include/srv0mon.ic 0.00% <0.00%> (-100.00%) ⬇️
... and 497 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lujiashun lujiashun marked this pull request as ready for review December 13, 2022 11:55
Comment thread storage/tianmu/loader/parsing_strategy.cpp
@lujiashun lujiashun added this to the stonedb_5.7_v1.0.2 milestone Dec 15, 2022
…tom#850,stoneatom#1006)

[summary]
1 support select into out-file can output enclose char(optionally or not);
2 support load with enclose char(optionally or not);
@mergify mergify Bot merged commit ad960cb into stoneatom:stonedb-5.7-dev Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-feature feature for pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: select..INTO OUTFILE..Add parameters:optionally enclosed by '"' escaped by '"' An error

3 participants