Skip to content

fix(tianmu): tianmu.primary_secondary_bit crashed or failed(#1212)#1233

Merged
mergify[bot] merged 1 commit intostoneatom:stonedb-5.7-devfrom
konghaiya:dev_lhj_1212
Jan 17, 2023
Merged

fix(tianmu): tianmu.primary_secondary_bit crashed or failed(#1212)#1233
mergify[bot] merged 1 commit intostoneatom:stonedb-5.7-devfrom
konghaiya:dev_lhj_1212

Conversation

@konghaiya
Copy link
Copy Markdown
Collaborator

@konghaiya konghaiya commented Jan 17, 2023

There is a problem with the judgment condition for obtaining the unique constraint. The key should be determined in advance_ Whether the number of parts is greater than 0

Summary about this PR

Issue Number: close #1212

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 17, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@konghaiya konghaiya self-assigned this Jan 17, 2023
@mergify mergify bot added the PR-bug bug for pull request label Jan 17, 2023
@konghaiya konghaiya added A-bug Something isn't working and removed PR-bug bug for pull request labels Jan 17, 2023
@konghaiya konghaiya added this to the stonedb_5.7_v1.0.3 milestone Jan 17, 2023
@mergify mergify bot added the PR-bug bug for pull request label Jan 17, 2023
@konghaiya konghaiya changed the title fix(tianmu): tianmu.primary_secondary_bit crashed or failed fix(tianmu): tianmu.primary_secondary_bit crashed or failed(#1212) Jan 17, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 17, 2023

Codecov Report

Base: 43.33% // Head: 43.35% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (7a90be8) compared to base (71a27c4).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 7a90be8 differs from pull request most recent head 55bcb62. Consider uploading reports for the commit 55bcb62 to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1233      +/-   ##
===================================================
+ Coverage            43.33%   43.35%   +0.01%     
===================================================
  Files                 1830     1830              
  Lines               396140   396142       +2     
===================================================
+ Hits                171682   171731      +49     
+ Misses              224458   224411      -47     
Impacted Files Coverage Δ
sql/log_event_push_cond.cc 83.21% <100.00%> (+0.23%) ⬆️
storage/innobase/sync/sync0arr.cc 53.38% <0.00%> (-0.85%) ⬇️
storage/tianmu/compress/top_bit_dict.cpp 61.53% <0.00%> (-0.66%) ⬇️
sql/sql_profile.cc 10.30% <0.00%> (-0.43%) ⬇️
storage/innobase/btr/btr0sea.cc 74.45% <0.00%> (-0.19%) ⬇️
storage/innobase/trx/trx0rec.cc 82.85% <0.00%> (-0.16%) ⬇️
storage/innobase/row/row0merge.cc 72.26% <0.00%> (-0.09%) ⬇️
storage/tianmu/core/engine.cpp 54.76% <0.00%> (+0.08%) ⬆️
storage/innobase/buf/buf0flu.cc 85.87% <0.00%> (+0.10%) ⬆️
storage/innobase/include/ib0mutex.h 72.20% <0.00%> (+0.37%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown

@lujiashun lujiashun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 17, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

…1212)

There is a problem with the judgment condition for obtaining the unique constraint. The key should be determined in advance_ Whether the number of parts is greater than 0
@mergify mergify bot merged commit aa6d316 into stoneatom:stonedb-5.7-dev Jan 17, 2023
@konghaiya konghaiya deleted the dev_lhj_1212 branch January 28, 2023 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-bug Something isn't working PR-bug bug for pull request

Projects

Development

Successfully merging this pull request may close these issues.

bug: MTR(tianmu.primary_secondary_bit/tianmu.zerofill) crashed or failed.

3 participants