Skip to content

feat(tianmu): unsupported DDL in SQL layer should report error. (#1185)#1246

Merged
mergify[bot] merged 4 commits intostoneatom:feat_filter_ddl_on_binlog_eventsfrom
lujiashun:feat-1185-stonedb5.7-for-feature-branch
Jan 31, 2023
Merged

feat(tianmu): unsupported DDL in SQL layer should report error. (#1185)#1246
mergify[bot] merged 4 commits intostoneatom:feat_filter_ddl_on_binlog_eventsfrom
lujiashun:feat-1185-stonedb5.7-for-feature-branch

Conversation

@lujiashun
Copy link
Copy Markdown

Summary about this PR

Issue Number: close #1185

[summary]
1 secondary/unique index report error;
2 full text/SPTIAL report error;
3 partition/foreign key report error;
4 GEOMETRY/SET/ENUM data type report error;
5 create trigger report error;

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@lujiashun lujiashun marked this pull request as draft January 29, 2023 02:19
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 29, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Jan 29, 2023
@lujiashun lujiashun changed the base branch from stonedb-5.7-dev to feat_filter_ddl_on_binlog_events January 29, 2023 02:20
@lujiashun lujiashun self-assigned this Jan 29, 2023
dependabot bot and others added 3 commits January 30, 2023 10:58
Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.31 to 0.7.33.
- [Release notes](https://github.com/faisalman/ua-parser-js/releases)
- [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md)
- [Commits](faisalman/ua-parser-js@0.7.31...0.7.33)

---
updated-dependencies:
- dependency-name: ua-parser-js
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
- Fixed the Roadmap style error on the home page
- Fixed Roadmap issue where the Chinese page could not locate the latest R&D block
- Other style optimization
@lujiashun lujiashun force-pushed the feat-1185-stonedb5.7-for-feature-branch branch 3 times, most recently from eff430f to 5bc0b77 Compare January 30, 2023 12:56
@lujiashun lujiashun closed this Jan 30, 2023
@lujiashun lujiashun reopened this Jan 30, 2023
…eatom#1185)

[summary]
1 secondary/unique index report error;
2 full text/SPTIAL report error;
3 partition/foreign key report error;
4 GEOMETRY/SET/ENUM data type report error;
5 create trigger report error;
@lujiashun lujiashun force-pushed the feat-1185-stonedb5.7-for-feature-branch branch from 5bc0b77 to 72aa590 Compare January 30, 2023 13:08
@lujiashun lujiashun marked this pull request as ready for review January 30, 2023 13:34
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 30, 2023

Codecov Report

❗ No coverage uploaded for pull request base (feat_filter_ddl_on_binlog_events@b1350c7). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                         Coverage Diff                         @@
##             feat_filter_ddl_on_binlog_events    #1246   +/-   ##
===================================================================
  Coverage                                    ?   43.24%           
===================================================================
  Files                                       ?     1830           
  Lines                                       ?   396179           
  Branches                                    ?        0           
===================================================================
  Hits                                        ?   171339           
  Misses                                      ?   224840           
  Partials                                    ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Collaborator

@DandreChen DandreChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 84e97ec into stoneatom:feat_filter_ddl_on_binlog_events Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-feature feature for pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: unsupported DDL in SQL layer should report error

5 participants