feat(stonedb): show stonedb tag version. (#1251)#1252
feat(stonedb): show stonedb tag version. (#1251)#1252mergify[bot] merged 1 commit intostoneatom:stonedb-5.7-devfrom
Conversation
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
ef982d1 to
1af591d
Compare
1af591d to
3adabd7
Compare
|
for debug version |
|
for release version: |
Codecov ReportBase: 43.39% // Head: 43.34% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## stonedb-5.7-dev #1252 +/- ##
===================================================
- Coverage 43.39% 43.34% -0.05%
===================================================
Files 1830 1830
Lines 396142 396143 +1
===================================================
- Hits 171888 171727 -161
- Misses 224254 224416 +162
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
3adabd7 to
6900467
Compare
| @@ -0,0 +1,3 @@ | |||
| select (select version() regexp '^5.7.36-StoneDB-v[0-9]*\\.[0-9]*\\.[0-9]*$') or (select version() regexp '^5.7.36-StoneDB-v[0-9]*\\.[0-9]*\\.[0-9]*\\.[0-9a-z]{9}$'); | |||
There was a problem hiding this comment.
if we upgrade our core to 5.7.4x, what will happen to this line code.
There was a problem hiding this comment.
the sql result wil be 0, need to modify the testcase if upgrade to 5.7.4x
| { | ||
| char *end= strxmov(server_version, MYSQL_SERVER_VERSION, | ||
| MYSQL_SERVER_SUFFIX_STR, NullS); | ||
| #if 0 |
There was a problem hiding this comment.
Add some comments here will be better?
Old code logic --> new code.
mysqld include storage engines like tianmu, innodb, myisam..., after we change the code, select version() acctually only shows tianmu version.
There was a problem hiding this comment.
OK, thanks, I will add some comment here later. select version() shows stonedb version, include the sql layer and storage layer include tianmu, innodb
6351e84 to
aafd632
Compare
aafd632 to
2019d0a
Compare
Summary about this PR
Issue Number: close #1251
Tests Check List
Changelog
Documentation