fix(tianmu):the data is wrong when altering table after deleting.(#1199)#1272
Merged
mergify[bot] merged 1 commit intostoneatom:stonedb-5.7-devfrom Feb 16, 2023
Merged
Conversation
Contributor
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
DandreChen
force-pushed
the
alter_delete
branch
4 times, most recently
from
10e858b to
a4caa11
Compare
Codecov ReportBase: 43.11% // Head: 43.12% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## stonedb-5.7-dev #1272 +/- ##
================================================
Coverage 43.11% 43.12%
================================================
Files 1830 1830
Lines 396311 396320 +9
================================================
+ Hits 170854 170897 +43
+ Misses 225457 225423 -34
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
DandreChen
force-pushed
the
alter_delete
branch
3 times, most recently
from
d661331 to
3857690
Compare
DandreChen
force-pushed
the
alter_delete
branch
2 times, most recently
from
828ccb5 to
3446379
Compare
DandreChen
requested review from
RingsC,
duanfuxiang0,
hustjieke,
isredstar,
lujiashun,
wisehead and
xuejiao-joy
and removed request for
xuejiao-joy
wisehead
suggested changes
Feb 16, 2023
DandreChen
force-pushed
the
alter_delete
branch
from
3446379 to
6b924d7
Compare
…neatom#1199) Because the records which was deleted is not filtered in fill_row().
DandreChen
force-pushed
the
alter_delete
branch
from
6b924d7 to
f2f000e
Compare
wisehead
approved these changes
Feb 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the records which was deleted is not filtered.
Summary about this PR
Issue Number: close #1199
[summary]
Because the records which was deleted is not filtered in fill_row().
Tests Check List
Changelog
Documentation