Skip to content

fix(tianmu):the data is wrong when updating data after atlering table.(#1253)#1297

Merged
mergify[bot] merged 1 commit intostoneatom:stonedb-5.7-devfrom
DandreChen:altertable_update
Feb 17, 2023
Merged

fix(tianmu):the data is wrong when updating data after atlering table.(#1253)#1297
mergify[bot] merged 1 commit intostoneatom:stonedb-5.7-devfrom
DandreChen:altertable_update

Conversation

@DandreChen
Copy link
Copy Markdown
Collaborator

Summary about this PR

Issue Number: close #1253

[summary]
After altering table add column, the data of the added column is NULL. When handling the NULL data, the updating operation is not correct.

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 14, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Feb 14, 2023
@DandreChen DandreChen self-assigned this Feb 14, 2023
@DandreChen DandreChen force-pushed the altertable_update branch 2 times, most recently from 3e193cb to ccc79c1 Compare February 16, 2023 07:31
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 16, 2023

Codecov Report

Base: 43.11% // Head: 43.13% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (4977453) compared to base (fb8d3be).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1297      +/-   ##
===================================================
+ Coverage            43.11%   43.13%   +0.01%     
===================================================
  Files                 1830     1830              
  Lines               396320   396321       +1     
===================================================
+ Hits                170857   170934      +77     
+ Misses              225463   225387      -76     
Impacted Files Coverage Δ
storage/tianmu/core/mysql_expression.cpp 86.86% <ø> (ø)
storage/tianmu/core/pack_str.cpp 63.41% <ø> (ø)
storage/tianmu/core/pack_int.cpp 67.49% <100.00%> (+0.51%) ⬆️
storage/innobase/include/dict0stats_bg.ic 50.00% <0.00%> (-50.00%) ⬇️
storage/innobase/sync/sync0arr.cc 50.84% <0.00%> (-2.55%) ⬇️
storage/innobase/dict/dict0stats_bg.cc 91.48% <0.00%> (-2.13%) ⬇️
storage/innobase/btr/btr0bulk.cc 80.89% <0.00%> (-0.96%) ⬇️
storage/tianmu/compress/top_bit_dict.cpp 66.15% <0.00%> (-0.66%) ⬇️
storage/innobase/buf/buf0buf.cc 45.90% <0.00%> (-0.51%) ⬇️
storage/innobase/row/row0ftsort.cc 69.49% <0.00%> (-0.34%) ⬇️
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

…stoneatom#1253)

After altering table add column, the data of the added column is NULL. When handling the
NULL data, the updating operation is not correct.
Copy link
Copy Markdown

@lujiashun lujiashun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 6a21184 into stoneatom:stonedb-5.7-dev Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-bug bug for pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: after ALTER table, UPDATE have something wrong.

3 participants