feat(sql): add NO_KEY_ERROR to sql_mode for ignoring unsupported error.(#1318)#1320
Merged
mergify[bot] merged 2 commits intostoneatom:stonedb-5.7-devfrom Feb 22, 2023
Merged
Conversation
…stoneatom#1318) Add NO_KEY_ERROR to sql_mode. Add judgement for secondary index、unique index、trigger、etc.
Contributor
|
This pull request's title should follow requirements next. @DandreChen please check it 👇. Valid format: Valid types:
|
Contributor
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
c3158dc to
4cf5b8b
Compare
wisehead
approved these changes
Feb 21, 2023
Add test cases for NO_KEY_ERROR to test secondary index、unique index and trigger.
4cf5b8b to
f32d655
Compare
Codecov ReportBase: 43.11% // Head: 43.11% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## stonedb-5.7-dev #1320 +/- ##
===================================================
- Coverage 43.11% 43.11% -0.01%
===================================================
Files 1830 1830
Lines 396374 396385 +11
===================================================
+ Hits 170904 170908 +4
- Misses 225470 225477 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
isredstar
approved these changes
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary about this PR
Issue Number: close #1318
[summary]
Add NO_KEY_ERROR to sql_mode.
Add judgement for secondary index、unique index、trigger、etc.
Add test cases for NO_KEY_ERROR to test secondary index、unique index and trigger.
Tests Check List
Changelog
Documentation