Skip to content

bug(tianmu):Server crashed, when execute select val, val >= '2010-02-22 18:35:23' from (select * from timetest) as A; (#981)#1321

Merged
mergify[bot] merged 5 commits intostoneatom:stonedb-5.7-devfrom
isredstar:stonedb-5.7-dev
Feb 22, 2023
Merged

bug(tianmu):Server crashed, when execute select val, val >= '2010-02-22 18:35:23' from (select * from timetest) as A; (#981)#1321
mergify[bot] merged 5 commits intostoneatom:stonedb-5.7-devfrom
isredstar:stonedb-5.7-dev

Conversation

@isredstar
Copy link
Copy Markdown
Collaborator

Summary about this PR

Issue Number: close #981

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 21, 2023

This pull request's title should follow requirements next. @isredstar please check it 👇.

Valid format:

fix(vc): fix sth..... (#3306)
  ^         ^---------^  ^----^
  |         |            |
  |         +            +-> you issue id.
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: feat, fix, docs, workflow, style, refactor, test, website, chore

Valid types:

  • feat: new feature for stonedb
  • fix: bug fix for stonedb
  • docs: changes to the documentation
  • workflow: ci/cd in .github
  • perf: Changes to improve code performance
  • refactor: refactoring production code, eg. renaming a variable
  • style: formatting, missing semi colons, etc; no production code change
  • test: adding missing tests, refactoring tests; no production code change
  • website
  • chore: updating grunt tasks etc; no production code change

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 21, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 21, 2023

Codecov Report

Base: 43.13% // Head: 43.13% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (4c66e71) compared to base (923c991).
Patch has no changes to coverable lines.

❗ Current head 4c66e71 differs from pull request most recent head d34bba2. Consider uploading reports for the commit d34bba2 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           stonedb-5.7-dev    #1321   +/-   ##
================================================
  Coverage            43.13%   43.13%           
================================================
  Files                 1830     1830           
  Lines               396385   396374   -11     
================================================
- Hits                170961   170958    -3     
+ Misses              225424   225416    -8     
Impacted Files Coverage Δ
sql/protocol_classic.cc 46.27% <ø> (ø)
storage/innobase/include/ut0mutex.ic 71.42% <0.00%> (-23.81%) ⬇️
storage/innobase/buf/buf0rea.cc 54.63% <0.00%> (-5.68%) ⬇️
storage/innobase/mach/mach0data.cc 83.78% <0.00%> (-5.41%) ⬇️
storage/innobase/row/row0umod.cc 63.46% <0.00%> (-3.21%) ⬇️
storage/innobase/include/ut0lst.h 81.06% <0.00%> (-1.95%) ⬇️
storage/innobase/mtr/mtr0mtr.cc 69.62% <0.00%> (-1.41%) ⬇️
storage/innobase/include/ib0mutex.h 71.82% <0.00%> (-0.75%) ⬇️
strings/ctype-simple.c 60.86% <0.00%> (-0.51%) ⬇️
storage/tianmu/core/pack_str.cpp 63.19% <0.00%> (-0.45%) ⬇️
... and 31 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@isredstar isredstar self-assigned this Feb 21, 2023
@isredstar isredstar added the PR-bug bug for pull request label Feb 21, 2023
Copy link
Copy Markdown
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 0f42505 into stoneatom:stonedb-5.7-dev Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-bug bug for pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Server crashed, when execute select val, val >= '2010-02-22 18:35:23' from (select * from timetest) as A;

3 participants