Skip to content

fix(tianmu):Solve the problem that index renaming is not supported(#1345)#1351

Merged
mergify[bot] merged 2 commits intostoneatom:stonedb-5.7-devfrom
konghaiya:dev_lhj_1345
Mar 7, 2023
Merged

fix(tianmu):Solve the problem that index renaming is not supported(#1345)#1351
mergify[bot] merged 2 commits intostoneatom:stonedb-5.7-devfrom
konghaiya:dev_lhj_1345

Conversation

@konghaiya
Copy link
Copy Markdown
Collaborator

@konghaiya konghaiya commented Mar 2, 2023 •
edited by Nliver
Loading

Modify points:

  1. Add (RENAME_INDEX) unsupported judgment conditions
  2. Remove the redundant filtering logic in (log_event. cpp)

Summary about this PR

Issue Number: close #1345
Issue Number: close #1056

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@konghaiya
fix(tianmu):Solve the problem that index renaming is not supported(st…
0f55186 
…oneatom#1345)

Modify points:
1. Add (RENAME_INDEX) unsupported judgment conditions
2. Remove the redundant filtering logic in (log_event. cpp)
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 2, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@konghaiya konghaiya self-assigned this Mar 2, 2023
@mergify mergify bot added the PR-bug bug for pull request label Mar 2, 2023
@konghaiya konghaiya added this to the stonedb_5.7_v1.0.3 milestone Mar 2, 2023
@konghaiya konghaiya requested a review from hustjieke March 2, 2023 09:43
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 2, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03 ⚠️

Comparison is base (bc15bbe) 43.15% compared to head (0f55186) 43.12%.

❗ Current head 0f55186 differs from pull request most recent head dbce77a. Consider uploading reports for the commit dbce77a to get more accurate results

Additional details and impacted files 
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1351      +/-   ##
===================================================
- Coverage            43.15%   43.12%   -0.03%     
===================================================
  Files                 1830     1830              
  Lines               396438   396388      -50     
===================================================
- Hits                171071   170959     -112     
- Misses              225367   225429      +62
Impacted Files Coverage Δ
sql/log_event.cc 34.85% <ø> (-0.07%) ⬇️
storage/tianmu/handler/ha_tianmu.cpp 56.03% <100.00%> (+0.18%) ⬆️
storage/tianmu/common/common_definitions.cpp 36.06% <0.00%> (-27.02%) ⬇️
storage/tianmu/exporter/export2file.cpp 80.00% <0.00%> (-8.00%) ⬇️
storage/tianmu/core/aggregator_advanced.cpp 41.13% <0.00%> (-7.81%) ⬇️
storage/tianmu/core/data_type.cpp 87.03% <0.00%> (-7.61%) ⬇️
storage/tianmu/core/aggregator_advanced.h 40.86% <0.00%> (-4.31%) ⬇️
sql/mdl.cc 66.11% <0.00%> (-3.33%) ⬇️
storage/tianmu/types/value_parser4txt.h 83.33% <0.00%> (-1.29%) ⬇️
strings/ctype-simple.c 60.86% <0.00%> (-1.18%) ⬇️
... and 36 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

hustjieke
hustjieke approved these changes Mar 7, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit a094688 into stoneatom:stonedb-5.7-dev Mar 7, 2023
@konghaiya konghaiya deleted the dev_lhj_1345 branch March 27, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RingsC RingsC Awaiting requested review from RingsC

@duanfuxiang0 duanfuxiang0 Awaiting requested review from duanfuxiang0

2 more reviewers

@wisehead wisehead wisehead approved these changes

@hustjieke hustjieke hustjieke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@konghaiya konghaiya

Labels

PR-bug bug for pull request

Projects

StoneDB for MySQL 5.7
Status: Done

Milestone

StoneDB_5.7_v1.0.3

3 participants

@konghaiya @wisehead @hustjieke