Skip to content

feat(tianmu): The error message displayed is inaccurate when you drop unique …#1356

Merged
mergify[bot] merged 3 commits intostoneatom:stonedb-5.7-devfrom
wisehead:DDL_drop_index_error
Mar 8, 2023
Merged

feat(tianmu): The error message displayed is inaccurate when you drop unique …#1356
mergify[bot] merged 3 commits intostoneatom:stonedb-5.7-devfrom
wisehead:DDL_drop_index_error

Conversation

@wisehead
Copy link
Copy Markdown
Collaborator

@wisehead wisehead commented Mar 7, 2023

…index or drop fulltext index. #1342,#1243

Summary about this PR

Issue Number: close #1342, close #1243

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 7, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Mar 7, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 7, 2023

Codecov Report

Patch coverage: 75.93% and project coverage change: +0.03 🎉

Comparison is base (7e3d1cd) 43.12% compared to head (43dcb35) 43.15%.

❗ Current head 43dcb35 differs from pull request most recent head fdf6d47. Consider uploading reports for the commit fdf6d47 to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1356      +/-   ##
===================================================
+ Coverage            43.12%   43.15%   +0.03%     
===================================================
  Files                 1830     1830              
  Lines               396395   396444      +49     
===================================================
+ Hits                170935   171089     +154     
+ Misses              225460   225355     -105     
Impacted Files Coverage Δ
storage/tianmu/core/data_type.h 63.63% <ø> (ø)
storage/tianmu/core/engine.cpp 54.56% <0.00%> (+0.30%) ⬆️
storage/tianmu/core/engine.h 30.43% <ø> (ø)
storage/tianmu/core/temp_table.cpp 71.71% <0.00%> (ø)
storage/tianmu/handler/ha_tianmu.cpp 55.85% <42.85%> (-0.19%) ⬇️
storage/tianmu/core/column_type.h 64.70% <50.00%> (ø)
storage/tianmu/core/mysql_expression.cpp 86.77% <50.00%> (-0.09%) ⬇️
storage/tianmu/core/tianmu_attr_typeinfo.h 78.12% <50.00%> (-1.88%) ⬇️
storage/tianmu/common/common_definitions.cpp 63.07% <53.84%> (+27.01%) ⬆️
storage/tianmu/core/engine_results.cpp 85.53% <90.90%> (+0.33%) ⬆️
... and 60 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@konghaiya konghaiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 06d88b8 into stoneatom:stonedb-5.7-dev Mar 8, 2023
@Nliver Nliver added this to the StoneDB_5.7_v1.0.3 milestone Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-feature feature for pull request

Projects

Development

Successfully merging this pull request may close these issues.

bug: The error message displayed is inaccurate when you drop unique index or drop fulltext index.

4 participants