Skip to content

fix(tianmu): modify the minimum value of bigint#1375

Merged
mergify[bot] merged 3 commits intostoneatom:stonedb-5.7-devfrom
El-even-11:stonedb-5.7-dev
Mar 10, 2023
Merged

fix(tianmu): modify the minimum value of bigint#1375
mergify[bot] merged 3 commits intostoneatom:stonedb-5.7-devfrom
El-even-11:stonedb-5.7-dev

Conversation

@El-even-11
Copy link
Copy Markdown
Contributor

Summary about this PR

Issue Number: close #1361

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 9, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Mar 9, 2023
Copy link
Copy Markdown
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

Signed-off-by: El-even-11 <zhao_ziqian@sjtu.edu.cn>
Signed-off-by: El-even-11 <zhao_ziqian@sjtu.edu.cn>
@hustjieke
Copy link
Copy Markdown
Collaborator

mtr runs error, you forget to fix the errors in signed_boundary.result:

--- /stonedb57/install/mysql-test/suite/tianmu/r/signed_boundary.result	2023-03-08 05:35:44.000000000 +0300
+++ /stonedb57/install/mysql-test/var/9/log/signed_boundary.reject	2023-03-09 13:21:17.076249651 +0300
@@ -14,7 +14,7 @@
 CREATE TABLE int64_(c_max bigint, c_min bigint) engine = tianmu;
 INSERT INTO int64_ values(-9223372036854775806, 9223372036854775807);
 INSERT INTO int64_ values(-9223372036854775807, 9223372036854775807);
-ERROR 22003: Out of range[-9223372036854775807, 9223372036854775807] for column 'c_max' value: -9223372036854775807
+ERROR 22003: Out of range[-9223372036854775806, 9223372036854775807] for column 'c_max' value: -9223372036854775807

Signed-off-by: El-even-11 <zhao_ziqian@sjtu.edu.cn>
@El-even-11
Copy link
Copy Markdown
Contributor Author

mtr runs error, you forget to fix the errors in signed_boundary.result:

--- /stonedb57/install/mysql-test/suite/tianmu/r/signed_boundary.result	2023-03-08 05:35:44.000000000 +0300
+++ /stonedb57/install/mysql-test/var/9/log/signed_boundary.reject	2023-03-09 13:21:17.076249651 +0300
@@ -14,7 +14,7 @@
 CREATE TABLE int64_(c_max bigint, c_min bigint) engine = tianmu;
 INSERT INTO int64_ values(-9223372036854775806, 9223372036854775807);
 INSERT INTO int64_ values(-9223372036854775807, 9223372036854775807);
-ERROR 22003: Out of range[-9223372036854775807, 9223372036854775807] for column 'c_max' value: -9223372036854775807
+ERROR 22003: Out of range[-9223372036854775806, 9223372036854775807] for column 'c_max' value: -9223372036854775807

Fixed. Thanks for your review!

@mergify mergify bot merged commit c040c50 into stoneatom:stonedb-5.7-dev Mar 10, 2023
@Nliver Nliver modified the milestone: stonedb_5.7_v1.0.3 Mar 10, 2023
@Nliver
Copy link
Copy Markdown
Collaborator

Nliver commented Mar 10, 2023

Nice job~

@Nliver Nliver linked an issue Mar 10, 2023 that may be closed by this pull request
3 tasks
@Nliver Nliver added this to the StoneDB_5.7_v1.0.3 milestone Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-bug bug for pull request

Projects

Development

Successfully merging this pull request may close these issues.

bug: the range of bigint value problem

4 participants