Skip to content

feat(index): Failed to insert a null value to the composite primary key. #1374#1377

Merged
mergify[bot] merged 1 commit intostoneatom:stonedb-5.7-devfrom
wisehead:bug1374_insert_empty_string_to_composite_primary_key
Mar 10, 2023
Merged

feat(index): Failed to insert a null value to the composite primary key. #1374#1377
mergify[bot] merged 1 commit intostoneatom:stonedb-5.7-devfrom
wisehead:bug1374_insert_empty_string_to_composite_primary_key

Conversation

@wisehead
Copy link
Copy Markdown
Collaborator

@wisehead wisehead commented Mar 10, 2023

Summary about this PR

Issue Number: close #issue_number_you_created

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 10, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Mar 10, 2023
@wisehead wisehead force-pushed the bug1374_insert_empty_string_to_composite_primary_key branch from 9a4cef8 to d97f39f Compare March 10, 2023 06:50
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 10, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c040c50) 43.11% compared to head (d97f39f) 43.11%.

Additional details and impacted files
@@               Coverage Diff                @@
##           stonedb-5.7-dev    #1377   +/-   ##
================================================
  Coverage            43.11%   43.11%           
================================================
  Files                 1836     1836           
  Lines               397199   397200    +1     
================================================
+ Hits                171240   171268   +28     
+ Misses              225959   225932   -27     
Impacted Files Coverage Δ
storage/tianmu/index/rdb_meta_manager.cpp 69.63% <100.00%> (+0.27%) ⬆️

... and 15 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Collaborator

@konghaiya konghaiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 51ce9a1 into stoneatom:stonedb-5.7-dev Mar 10, 2023
@Nliver Nliver added this to the stonedb_5.7_v1.0.3 milestone Mar 10, 2023
@Nliver Nliver linked an issue Mar 10, 2023 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-feature feature for pull request

Projects

Development

Successfully merging this pull request may close these issues.

bug: Failed to insert a null value to the composite primary key.

4 participants