Skip to content

support exists/in subquery convert to semi-join#1379

Merged
mergify[bot] merged 4 commits into
stoneatom:stonedb-5.7-devfrom
duanfuxiang0:semi-join-new
Mar 10, 2023
Merged

support exists/in subquery convert to semi-join#1379
mergify[bot] merged 4 commits into
stoneatom:stonedb-5.7-devfrom
duanfuxiang0:semi-join-new

Conversation

@duanfuxiang0
Copy link
Copy Markdown
Contributor

Summary about this PR

Issue Number: close #864

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 10, 2023

This pull request's title should follow requirements next. @duanfuxiang0 please check it 👇.

Valid format:

fix(vc): fix sth..... (#3306)
  ^         ^---------^  ^----^
  |         |            |
  |         +            +-> you issue id.
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: feat, fix, docs, workflow, style, refactor, test, website, chore

Valid types:

  • feat: new feature for stonedb
  • fix: bug fix for stonedb
  • docs: changes to the documentation
  • workflow: ci/cd in .github
  • perf: Changes to improve code performance
  • refactor: refactoring production code, eg. renaming a variable
  • style: formatting, missing semi colons, etc; no production code change
  • test: adding missing tests, refactoring tests; no production code change
  • website
  • chore: updating grunt tasks etc; no production code change

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 10, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

Copy link
Copy Markdown
Collaborator

@konghaiya konghaiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 10, 2023

Codecov Report

Patch coverage: 86.58% and project coverage change: +42.92 🎉

Comparison is base (f4fd486) 0.00% compared to head (31b41af) 42.92%.

❗ Current head 31b41af differs from pull request most recent head c35d5b7. Consider uploading reports for the commit c35d5b7 to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                  @@
##           stonedb-5.7-dev    #1379       +/-   ##
====================================================
+ Coverage                 0   42.92%   +42.92%     
====================================================
  Files                    0     1836     +1836     
  Lines                    0   397306   +397306     
====================================================
+ Hits                     0   170547   +170547     
- Misses                   0   226759   +226759     
Impacted Files Coverage Δ
storage/tianmu/core/query_compile.cpp 69.11% <79.38%> (ø)
storage/tianmu/core/query.h 87.50% <87.50%> (ø)
storage/tianmu/core/query.cpp 69.40% <88.88%> (ø)
sql/sql_resolver.cc 78.79% <100.00%> (ø)

... and 1832 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wisehead wisehead self-requested a review March 10, 2023 09:06
@mergify mergify Bot merged commit 25eff02 into stoneatom:stonedb-5.7-dev Mar 10, 2023
@Nliver Nliver added the PR-feature feature for pull request label Apr 15, 2023
@Nliver Nliver added this to the StoneDB_5.7_v1.0.3 milestone Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-feature feature for pull request

Projects

Development

Successfully merging this pull request may close these issues.

feature: support semi-join in stonedb, include EXISTS and IN subqueries

4 participants