fix(core): incorrect result when execute sql with between | > or < in or not in #1332#1393
Merged
mergify[bot] merged 3 commits intostoneatom:stonedb-5.7-devfrom Mar 17, 2023
Conversation
…in or not in stoneatom#1332 [summary] In tianmu, pack_int uses uint64_t to store level 2 encode, ranges from [0, uint64_max], so when filter data, the conditions(in code named "pv1, pv2") should be also changed to level 2 encode. e.g.: stored value = actually value - min uint64 upv1 = pv1 - local_min; uint64 upv2 = local_max - local_min; the fixes mainly in funciont "EvaluatePack_BetweenInt". For not int (value): when value < local_min, it should be a special case. Only used when rough check = RS_ALL(no numeric data matchs), but table has null, rough check will be reset RS_SOME.
Contributor
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
wisehead
approved these changes
Mar 16, 2023
Collaborator
wisehead
left a comment
wisehead
left a comment
There was a problem hiding this comment.
reviewed the code hustjieke via tencent meeting, looks good to me.
RingsC
suggested changes
Mar 17, 2023
…ag --> (pv2 < local_min) stoneatom#1332
RingsC
approved these changes
Mar 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary about this PR
In tianmu, pack_int uses uint64_t to store level 2 encode, ranges from [0, uint64_max], so when filter data, the conditions(in code named "pv1, pv2") should be also changed to level 2 encode. e.g.: stored value = actually value - min
uint64 upv1 = pv1 - local_min;
uint64 upv2 = local_max - local_min;
the fixes mainly in funciont "EvaluatePack_BetweenInt".
For not int (value): when value < local_min, it should be a special case. Only used when rough check = RS_ALL(no numeric data matchs), but table has null, rough check will be reset RS_SOME.
Issue Number: close #1332
Tests Check List
Changelog
Documentation