fix(tianmu): fix mysqld crash when exec query limit 0 (#1394)#1395
Merged
mergify[bot] merged 1 commit intostoneatom:stonedb-5.7-devfrom Mar 17, 2023
adofsauron:stonedb-5.7-dev
Merged
fix(tianmu): fix mysqld crash when exec query limit 0 (#1394)#1395mergify[bot] merged 1 commit intostoneatom:stonedb-5.7-devfrom adofsauron:stonedb-5.7-dev
mergify[bot] merged 1 commit intostoneatom:stonedb-5.7-devfrom
adofsauron:stonedb-5.7-dev
Conversation
Contributor
|
This pull request's title should follow requirements next. @adofsauron please check it 👇. Valid format: Valid types:
|
Contributor
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
RingsC
previously requested changes
Mar 15, 2023
haitaoguan
approved these changes
Mar 17, 2023
Cause: tianmu engine cannot process this scenario when limit=0 and cannot get conds, resulting in crash
Solution: limit 0 is executed without tianmu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause: tianmu engine cannot process this scenario when limit=0 and cannot get conds, resulting in crash
Solution: limit 0 is executed without tianmu
Summary about this PR
Issue Number: close #1394
Tests Check List
Changelog
Documentation