Skip to content

feat(tianmu):support the ALTER syntax, ALTER table t1 rename t2, add c char(10) (#760)#901

Merged
mergify[bot] merged 1 commit intostoneatom:stonedb-5.7-devfrom
DandreChen:stonedb-5.7-dev
Nov 10, 2022
Merged

feat(tianmu):support the ALTER syntax, ALTER table t1 rename t2, add c char(10) (#760)#901
mergify[bot] merged 1 commit intostoneatom:stonedb-5.7-devfrom
DandreChen:stonedb-5.7-dev

Conversation

@DandreChen
Copy link
Copy Markdown
Collaborator

Summary about this PR

Issue Number: close #760

[summary]
fix some warnings
add mtr for alter table
support alter table: mix add/drop column、order column and other syntaxs to use

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 8, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Nov 8, 2022
@DandreChen DandreChen force-pushed the stonedb-5.7-dev branch 3 times, most recently from e60700d to 9b6bd0a Compare November 9, 2022 05:49
Copy link
Copy Markdown
Contributor

@duanfuxiang0 duanfuxiang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DandreChen DandreChen requested a review from RingsC November 10, 2022 03:12
Copy link
Copy Markdown
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 10, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@DandreChen DandreChen self-assigned this Nov 10, 2022
…c char(10) (stoneatom#760)

fix some warnings
add/fix mtr for alter table
support alter table: mix add/drop column、order column and other syntaxs to use
@mergify mergify bot merged commit 02cb94c into stoneatom:stonedb-5.7-dev Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-feature feature for pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: Dose not support the ALTER syntax, ALTER table t1 rename t2, add c char(10);

3 participants