Skip to content

feat(tianmu): support the syntax of 'select..where like NULL' (#763)#908

Merged
mergify[bot] merged 7 commits intostoneatom:stonedb-5.7-devfrom
isredstar:stonedb-5.7-dev
Nov 14, 2022
Merged

feat(tianmu): support the syntax of 'select..where like NULL' (#763)#908
mergify[bot] merged 7 commits intostoneatom:stonedb-5.7-devfrom
isredstar:stonedb-5.7-dev

Conversation

@isredstar
Copy link
Copy Markdown
Collaborator

@isredstar isredstar commented Nov 9, 2022

Summary about this PR

Issue Number: close #763
add sql syntax：Arguments of like is NULL
add mtr for like NULL

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 9, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Nov 9, 2022
lujiashun
lujiashun approved these changes Nov 9, 2022
View reviewed changes
Copy link
Copy Markdown

@lujiashun lujiashun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RingsC
RingsC suggested changes Nov 11, 2022
View reviewed changes
RingsC
RingsC approved these changes Nov 14, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Great Job.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 14, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot merged commit 08ac72f into stoneatom:stonedb-5.7-dev Nov 14, 2022
@Nliver Nliver added this to the StoneDB_5.7_v1.0.2 milestone Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@duanfuxiang0 duanfuxiang0 Awaiting requested review from duanfuxiang0

@hustjieke hustjieke Awaiting requested review from hustjieke

2 more reviewers

@RingsC RingsC RingsC approved these changes

@lujiashun lujiashun lujiashun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@isredstar isredstar

Labels

PR-feature feature for pull request

Projects

StoneDB for MySQL 5.7
Status: Done

Milestone

StoneDB_5.7_v1.0.2

Development

Successfully merging this pull request may close these issues.

bug: Tianmu error ERROR 6 (HY000)，when execute select..where like NULL

4 participants

@isredstar @RingsC @lujiashun @Nliver