Merged
Conversation
…ervice Both Vantage and QueueMonitorController maintained identical copies of the payload restoration logic. Extract it into a dedicated JobRestorer service class that consolidates the best of both implementations — full structured logging at every failure point and secure unserialize with allowed_classes.
houdaslassi
force-pushed
the
refactor/enhancements
branch
from
1d76b29 to
62f61c5
Compare
The three QueueMonitorController reflection-based tests broke when restoreJobFromPayload was extracted into JobRestorer. Point them at JobRestorer::restore() so the security coverage stays intact.
- Add @Property PHPDoc annotations to VantageJob model so PHPStan recognises all dynamic Eloquent columns (status, job_class, payload, telemetry fields, etc.) without needing ignore rules - Add missing `use Illuminate\Support\Str` import in RecordJobSuccess - Fix Vantage::queueDepth() to call QueueDepthChecker::getQueueDepth() instead of the non-existent check() method - Regenerate phpstan-baseline.neon, removing ~330 stale patterns that still referenced the old HoudaSlassi\Vantage namespace
- Change @Property string \$connection to string|null on VantageJob so the nullCoalesce in RetryFailedJob no longer triggers the warning, which avoids a stale baseline entry that only fired locally - Remove the now-unnecessary nullCoalesce.property baseline entry for RetryFailedJob.php - Add view-string ignore (reportUnmatched: false) in phpstan.neon.dist for Larastan's view-name type check; package views are not registered at analysis time so this is a false positive, and reportUnmatched prevents the rule itself from erroring on environments where Larastan does not enforce view-string types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.