Skip to content

Conversation

@yannbf
Copy link
Member

@yannbf yannbf commented Dec 3, 2025

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Chores
    • Sandbox termination no longer removes the Yarn Berry cache directory; the cache is preserved after sandbox finalization.
    • No other functional behavior changes were introduced in this update.

✏️ Tip: You can customize this high-level summary in your review settings.

@yannbf yannbf self-assigned this Dec 3, 2025
@yannbf yannbf added build Internal-facing build tooling & test updates ci:normal labels Dec 3, 2025
@nx-cloud
Copy link

nx-cloud bot commented Dec 3, 2025

View your CI Pipeline Execution ↗ for commit cbfe150

Command Status Duration Result
nx run-many -t compile,check,knip,test,pretty-d... ❌ Failed 4h 7m View ↗

☁️ Nx Cloud last updated this comment at 2025-12-03 18:02:33 UTC

@nx-cloud
Copy link

nx-cloud bot commented Dec 3, 2025

View your CI Pipeline Execution ↗ for commit a65f5ee

Command Status Duration Result
nx run-many -t compile --parallel=3 ✅ Succeeded 45s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-03 11:33:21 UTC

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 3, 2025

📝 Walkthrough

Walkthrough

Removed the import of homedir and the finalization code that deleted the Yarn Berry cache directory; the sandbox generation script no longer removes the cache at ~/.yarn/berry during termination.

Changes

Cohort / File(s) Summary
Sandbox generation script
scripts/sandbox/generate.ts
Removed the homedir import and deleted the finalization block that cleaned up the Yarn Berry cache directory (~/.yarn/berry), so the cache is retained after sandbox generation completes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Single-file change with small removals.
  • Check for any remaining references to homedir and whether retaining the cache impacts disk usage or subsequent runs.

Possibly related PRs

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a65f5ee and cbfe150.

📒 Files selected for processing (1)
  • scripts/sandbox/generate.ts (0 hunks)
💤 Files with no reviewable changes (1)
  • scripts/sandbox/generate.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: normal
  • GitHub Check: Core Unit Tests, windows-latest
  • GitHub Check: nx

Comment @coderabbitai help to get the list of available commands and usage tips.

@yannbf yannbf force-pushed the yann/do-not-remove-yarn-dir branch from a65f5ee to cbfe150 Compare December 3, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:normal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants