Storybook: Rolldown optimized #33269
Draft
+296
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply plugin hook filters to Vite plugins to optimize performance by reducing Rust-to-JS communication overhead. Filters allow Rolldown/Vite to determine whether hooks need to be invoked without leaving Rust. Changes: - Add filter to code-generator-plugin for virtual module IDs - Add filter to external-globals-plugin for packages in code - Add filter to inject-export-order-plugin for story files - Add filter to strip-story-hmr-boundaries for story files - Add filter to vite-inject-mocker load hook All filters include fallback checks in handlers to maintain backward compatibility with Vite versions < 6.3.0 that don't support filters. Note: Previous work by another agent included: - Fixed Vue3 renderer bug for URL args in isolation mode - Fixed Prettier type leakage issue - Removed mocking utilities registration
…ization Implement support for Rolldown's native MagicString in Vite builder plugins to enable significant performance improvements when available. Changes: - Update external-globals-plugin to detect and use native MagicString - Update inject-export-order-plugin with native MagicString support - Update strip-story-hmr-boundaries with native MagicString support - Add fallback logic for backward compatibility with regular Vite - Add comprehensive tests for native MagicString functionality - Add documentation explaining the implementation and benefits Performance benefits (based on Rolldown benchmarks): - 1.15x to 1.33x faster build times - 1.63x to 2.26x faster plugin transform times - Greater improvements with larger codebases The implementation maintains full backward compatibility: - Works with regular Vite (uses JavaScript MagicString) - Works with older Vite versions (< 6.3.0) - Works with Rolldown (uses native MagicString when available) - No configuration changes required for users
Contributor
|
View your CI Pipeline Execution ↗ for commit f9786a2
☁️ Nx Cloud last updated this comment at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-33269-sha-f9786a2f. Try it out in a new sandbox by runningnpx [email protected] sandboxor in an existing project withnpx [email protected] upgrade.More information
0.0.0-pr-33269-sha-f9786a2fvalentin/rolldown-optimizedf9786a2f1764770350)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=33269