A11y: Add ScrollArea prop focusable for when it has static children#33876
A11y: Add ScrollArea prop focusable for when it has static children#33876
Conversation
|
View your CI Pipeline Execution ↗ for commit 8b0f92b
☁️ Nx Cloud last updated this comment at |
|
View your CI Pipeline Execution ↗ for commit b067cf5 ☁️ Nx Cloud last updated this comment at |
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughAdds a boolean Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes ✨ Finishing Touches
Comment |
Package BenchmarksCommit: No significant changes detected, all good. 👏 |
b067cf5 to
8b0f92b
Compare
Fixes https://www.chromatic.com/test?appId=635781f3500dd2c49e189caf&id=699774e0d5f9296fd0ff61a1&panel=accessibility-panel
What I did
Fixed an a11y violation whereby scrollable areas cannot be reached via keyboard (https://dequeuniversity.com/rules/axe/4.10/scrollable-region-focusable?application=axeAPI / SC 2.1.1).
Added a prop for ScrollArea letting us mark it as focusable when we know our own scrollable content is entirely static (e.g. code snippets in syntax highlighter).
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Note
YOU MUST TEST WITH FIREFOX, NOT CHROME. Chrome makes scroll areas focusable by default.
Documentation
ø
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>Summary by CodeRabbit