React: Fix manifest stories empty when meta has no explicit title#33878
Merged
kasperpeulen merged 1 commit intonextfrom Feb 20, 2026
Merged
React: Fix manifest stories empty when meta has no explicit title#33878kasperpeulen merged 1 commit intonextfrom
kasperpeulen merged 1 commit intonextfrom
Conversation
|
View your CI Pipeline Execution ↗ for commit 5833e6b
☁️ Nx Cloud last updated this comment at |
Contributor
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughChanged the component manifest generator's CSF-title fallback to use the manifest entry's title when meta.title is absent. Added tests asserting stories are populated using the index entry title; tests duplicate the same assertion twice. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
✨ Finishing Touches
Comment |
a097a67 to
9b85ba0
Compare
When a story file has no explicit `title` in its meta (the common case), the CSF parser received 'No title' as fallback, producing wrong story IDs (e.g. `no-title--logged-in` instead of `header--logged-in`). These IDs didn't match the index entries, so `extractStories` filtered them all out, resulting in empty `stories: []` in the manifest. Use `entry.title` from the story index as fallback instead.
9b85ba0 to
5833e6b
Compare
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 2 | 2 | 0 |
| Self size | 402 KB | 391 KB | 🎉 -11 KB 🎉 |
| Dependency size | 338 KB | 338 KB | 0 B |
| Bundle Size Analyzer | Link | Link |
JReinhold
approved these changes
Feb 20, 2026
This was referenced Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
Fixed component manifest generating empty
stories: []when story files don't have an explicittitlein their meta object (the common case — Storybook auto-generates titles from file paths).The manifest generator re-parses story files with
loadCsf()and needs amakeTitlecallback to compute the title. Previously, the fallback was'No title', causing the CSF parser to generate wrong story IDs (e.g.no-title--logged-ininstead ofheader--logged-in). SinceextractStoriesfilters by matching against the index entry IDs, none matched — resulting in emptystories: [].The fix: always use
entry.titlefrom the story index, which was already correctly computed by theStoryIndexGenerator(viauserOrAutoTitleFromSpecifier). There's no need to inspect the user's title from the file since the index already has the canonical answer.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Caution
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
titlein their meta (the common/default case)features: { experimentalComponentsManifest: true }in.storybook/main.tsstorybook buildorstorybook dev/manifests/components.json— stories should now be populated for all components, not just those with explicit titlesDocumentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>Summary by CodeRabbit
Bug Fixes
Tests