Skip to content

Comments

Build: Optimize sandbox generation scripts in link mode#33880

Open
valentinpalkovic wants to merge 2 commits intonextfrom
valentin/optimize-sandbox-generation-scripts
Open

Build: Optimize sandbox generation scripts in link mode#33880
valentinpalkovic wants to merge 2 commits intonextfrom
valentin/optimize-sandbox-generation-scripts

Conversation

@valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Feb 20, 2026

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Caution

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Chores
    • Broadened template support by adding three additional Next.js + Vite variants to resolution logic, improving compatibility for more project templates and influencing React/react-dom version overrides where applicable.
    • Simplified internal compilation verification: build success is now determined by presence of expected output files, reducing reliance on file content inspection.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2026

Fails
🚫 The "#### Manual testing" section must be filled in. Please describe how to test the changes you've made, step by step, so that reviewers can confirm your PR works as intended.

Generated by 🚫 dangerJS against 4ffbc7a

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 20, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

Simplified compilation ready check in scripts/tasks/compile.ts: removed linkedContents-based inspection and now treat successful file reads (index.js when linking, index.d.ts otherwise) as success. Expanded additionalReact19Resolutions in scripts/utils/yarn.ts with three Next.js + Vite template keys.

Changes

Cohort / File(s) Summary
Compilation Logic Simplification
scripts/tasks/compile.ts
Removed exported linkedContents usage and removed logic that inspected index.d.ts to infer compilation status. compile.ready now reads index.js when linking and index.d.ts when not, returning success based on successful file read rather than file content.
React 19 Resolution Expansion
scripts/utils/yarn.ts
Added three new Next.js + Vite template keys to additionalReact19Resolutions: nextjs-vite/15-ts, nextjs-vite/default-ts, and nextjs-vite/14-ts. No other logic changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)

Comment @coderabbitai help to get the list of available commands and usage tips.

@valentinpalkovic valentinpalkovic added build Internal-facing build tooling & test updates ci:normal labels Feb 20, 2026
@nx-cloud
Copy link

nx-cloud bot commented Feb 20, 2026

View your CI Pipeline Execution ↗ for commit 4ffbc7a

Command Status Duration Result
nx run-many -t compile,check,knip,test,pretty-d... ❌ Failed 10m 49s View ↗

☁️ Nx Cloud last updated this comment at 2026-02-20 13:07:55 UTC

@nx-cloud
Copy link

nx-cloud bot commented Feb 20, 2026

View your CI Pipeline Execution ↗ for commit 2f85e31


☁️ Nx Cloud last updated this comment at 2026-02-20 11:15:27 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:normal

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

1 participant