Limit IPAccount Storage Writes to Registered Modules#103
Merged
LeoHChen merged 4 commits intostoryprotocol:mainfrom Apr 15, 2024
Merged
Limit IPAccount Storage Writes to Registered Modules#103LeoHChen merged 4 commits intostoryprotocol:mainfrom
LeoHChen merged 4 commits intostoryprotocol:mainfrom
Conversation
kingster-will
requested review from
AndyBoWu,
LeoHChen,
Ramarti,
Spablob,
jdubpark and
leeren
as code owners
LeoHChen
reviewed
Apr 15, 2024
LeoHChen
approved these changes
Apr 15, 2024
LeoHChen
left a comment
LeoHChen
left a comment
There was a problem hiding this comment.
LGTM in general, is there any security risk with create3 to deploy the accountimpl? do we want to use the same accountimpl cross multiple chains?
jdubpark
reviewed
Apr 15, 2024
|
please rebase the code. |
kingster-will
changed the title
kingster-will
force-pushed
the
v1/ipaccount-storage-limit
branch
from
2d2ee14 to
dcb4f8f
Compare
Collaborator
Author
Rebased |
LeoHChen
approved these changes
Apr 15, 2024
jdubpark
approved these changes
Apr 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to the IPAccount storage. Here's a brief overview of the changes:
We have now limited the ability to write into the IPAccount storage. With this update, only register modules and core registries will have the write access.
Closes #84