Integration with Solday's ERC6551 Implementation#133
Merged
LeoHChen merged 5 commits intostoryprotocol:mainfrom Apr 25, 2024
Merged
Integration with Solday's ERC6551 Implementation#133LeoHChen merged 5 commits intostoryprotocol:mainfrom
LeoHChen merged 5 commits intostoryprotocol:mainfrom
Conversation
LeoHChen
reviewed
Apr 25, 2024
jdubpark
reviewed
Apr 25, 2024
|
For tests, it'd be better to use parameterized internal functions for repetitive code, e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Overview
This PR introduces integration with Solday's ERC6551 smart contract. Key modifications include the update of the
statevariable, renaming it fromnonceand changing its type fromuint256tohash (bytes32). This adjustment ensures thatstateis now deterministic, computed from the input parameters of theexecute()function.Modifications
statefromuint256tobytes32according to Solady 6551, which is hash computed based onexecute()inputs. All execute functionsexecute()',executeBatch()andexecuteWithSig()share the function to update 'state' which calculate hash based on common inputs of execute functions:to,valueanddata`.execute()andexecuteBatch()methods from Solady ERC6551 to include check permissions via AccessController. This ensures that every execution undergoes a permission verification process.Test Plan
All new added code covered by automation tests.
Related Issue
Closes #83