Introducing Core Metadata Module and View Module#15
Introducing Core Metadata Module and View Module#15LeoHChen merged 14 commits intostoryprotocol:mainfrom
Conversation
|
So the core metadata come from two places ? One in the IPA, another in the registry? |
Ramarti
left a comment
There was a problem hiding this comment.
Is this going to replace IPAssetRegistry?
In which step will this contract be called in the registration process?
|
Noting for future PRs, for the core vs periphery division, I strongly see the view modules as periphery modules as they interact with core components (and none of our core modules interact with view modules). |
All core metadata come from IPAccount, while just under two namespaces, one is under namespace of IPAssetRegistry. |
Nope, it is not for replacing IPAssetRegistry. This contract is supposed to be called after the IPA is registered with IPAssetRegitry. |
Agree the future View Modules will be created in the periphery repo. Only the CoreMetadtaViewModule is needed in the core repo. |
What's the difference between metadata under this namespace and under IPAssetRegistry? Would it be the type of metadata stored? |
jdubpark
left a comment
There was a problem hiding this comment.
Looks good, requesting natspec comment changes
d54311d to
336f2e9
Compare
Correct Calculation of Claimable Royalty for Ancestor IPs
This PR introduces the
CoreMetadataModuleandCoreMetadataViewModuleto the Story Protocol. These modules enable IP asset owners to set common metadata for their IP assets post-registration. Once set, this core metadata is immutable and cannot be changed. TheCoreMetadataViewModulefacilitates the retrieval of this core metadata and generates a JSON metadata string representing it.CoreMetadataModule
The
CoreMetadataModuleallows IP asset owners to set essential metadata attributes such as name, description, and content hash. These attributes are critical for identifying and describing the IP assets within the Story Protocol ecosystem. The module ensures that each piece of metadata can only be set once, enforcing immutability and preserving the integrity of the IP asset's core information.Key Features
CoreMetadataViewModule
The
CoreMetadataViewModuleprovides functionalities to retrieve the core metadata of IP assets and generate a JSON string representing all core metadata. This module is essential for external integrations and user interfaces that require access to an IP asset's metadata in a standardized format.Key Features