Introduce maxRevenueShare for Minting License Tokens and Registering Derivatives#364
Merged
kingster-will merged 1 commit intostoryprotocol:mainfrom Dec 14, 2024
Merged
Conversation
sebsadface
approved these changes
Dec 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new feature that allows users to specify the maximum royalty percentage (
maxRevenueShare) they are willing to accept when minting license tokens from an IP or registering a derivative to parent IPs. This change enhances the flexibility and control users have over their licensing agreements.Key Changes
maxRevenueShareParameter: Added amaxRevenueShareparameter to the functions for minting license tokens and registering derivatives.maxRevenueShareis not exceeded during the minting or registration process.Closes https://github.com/storyprotocol/trust-protocol-contracts-v1/issues/17