Remove IP-Level Licensing Configuration#392
Merged
sebsadface merged 4 commits intostoryprotocol:mainfrom Feb 4, 2025
Merged
Conversation
kingster-will
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR removes the ability to set licensing configurations at the IP level, requiring all configurations to be set at the specific license template and terms ID level.
Key Changes
LicensingModule.sol
setLicensingConfig()to require both licenseTemplate and licenseTermsId parametersLicenseRegistry.sol
getLicensingConfig()to only return license-specific configurationsTests
Motivation
The previous implementation allowed licensing configurations to be set at both the IP level and license-specific level, which created:
This change enforces a simpler, more explicit model where all configurations must be set at the license level.