Remove ancestors hash and royalty context requirement from royalty LAP policy#4
Merged
jdubpark merged 8 commits intostoryprotocol:mainfrom Mar 18, 2024
Merged
Conversation
jdubpark
reviewed
Mar 18, 2024
jdubpark
reviewed
Mar 18, 2024
jdubpark
left a comment
jdubpark
left a comment
There was a problem hiding this comment.
Some comments left.
Also, can you write the tradeoff of this change, ie. gas cost increase, in this PR? Thanks!
kingster-will
pushed a commit
to kingster-will/protocol-core-v1-dev
that referenced
this pull request
Jan 18, 2025
Make claim and identifier parameters not user defined in arbitration policy UMA
kingster-will
pushed a commit
to kingster-will/protocol-core-v1-dev
that referenced
this pull request
Jan 31, 2025
kingster-will
pushed a commit
that referenced
this pull request
Jan 31, 2025
irfand29
pushed a commit
to irfand29/protocol-core-v1
that referenced
this pull request
Feb 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr:
The goal of the changes is to greatly improve integrability as external projects no longer need to request the SDK to obtain the royaltyContext input when setting up a royalty policy. Gas increased by around 50% as previously discussed for initPolicy. Developer experience and ease of setup are greatly improved as there is no need to retrieve and understand the previously existing royalty context data struct.